Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): add borderAccentLight #2783

Merged
merged 3 commits into from
Feb 3, 2020
Merged

feat(theme): add borderAccentLight #2783

merged 3 commits into from
Feb 3, 2020

Conversation

sandgraham
Copy link
Contributor

Updates borderAccent and adds a new semantic color token with the old value: borderAccentLight.

@vercel
Copy link

vercel bot commented Feb 1, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/uber-ui-platform/baseweb/c8kfca0af
✅ Preview: https://baseweb-git-token-update.uber-ui-platform.now.sh

@tajo
Copy link
Member

tajo commented Feb 3, 2020

Should be also added to the extension cheat sheet.

@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Feb 3, 2020
Closed
@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #2787

@UberOpenSourceBot
Copy link
Contributor

Visual changes have been resolved. #2787 has been closed. If future commits on token-update trigger visual changes, a new snapshot branch will be created and a new PR will be opened.

@sandgraham
Copy link
Contributor Author

@tajo Is adding to cheatsheet just adding it to the App.tsx file like I did?

@tajo
Copy link
Member

tajo commented Feb 3, 2020

@tajo Is adding to cheatsheet just adding it to the App.tsx file like I did?

Yes

@sandgraham sandgraham merged commit 2cc7735 into master Feb 3, 2020
@uber-baseweb-probots uber-baseweb-probots bot deleted the token-update branch February 3, 2020 22:45
VladimirMilenko pushed a commit to VladimirMilenko/baseui that referenced this pull request Apr 2, 2020
@sandgraham @VladimirMilenko
feat(theme): add borderAccentLight (uber#2783)
93d33b8 
* feat(theme): add borderAccentLight

* chore: add new token to vscode cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajo tajo tajo approved these changes

@nadiia nadiia nadiia approved these changes

@chasestarr chasestarr Awaiting requested review from chasestarr

@gergelyke gergelyke Awaiting requested review from gergelyke

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
4 participants
@sandgraham @tajo @UberOpenSourceBot @nadiia